fix: return independent metadata dicts from normalize_metadata - #12107
fix: return independent metadata dicts from normalize_metadata#12107DivyaNarahari97 wants to merge 1 commit into
Conversation
normalize_metadata returned the same dict object repeated across sources
([{}] * n / [meta] * n), so mutating one source's metadata leaked into all
the others. Each source now receives its own independent copy. Also removes
the now-redundant local workaround in FileToFileContent.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@DivyaNarahari97 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi @DivyaNarahari97, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
|
Hi @DivyaNarahari97, just a friendly reminder: this PR is still in draft because the Contributor License Agreement (CLA) hasn't been signed yet. We'd love to review your contribution! Please sign the CLA via the link in the |
normalize_metadata returned the same dict object repeated across sources ([{}] * n / [meta] * n), so mutating one source's metadata leaked into all the others. Each source now receives its own independent copy. Also removes the now-redundant local workaround in FileToFileContent.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.