Skip to content

fix: return independent metadata dicts from normalize_metadata - #12107

Draft
DivyaNarahari97 wants to merge 1 commit into
deepset-ai:mainfrom
DivyaNarahari97:fix/normalize-metadata-shared-dict
Draft

fix: return independent metadata dicts from normalize_metadata#12107
DivyaNarahari97 wants to merge 1 commit into
deepset-ai:mainfrom
DivyaNarahari97:fix/normalize-metadata-shared-dict

Conversation

@DivyaNarahari97

Copy link
Copy Markdown

normalize_metadata returned the same dict object repeated across sources ([{}] * n / [meta] * n), so mutating one source's metadata leaked into all the others. Each source now receives its own independent copy. Also removes the now-redundant local workaround in FileToFileContent.

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

normalize_metadata returned the same dict object repeated across sources
([{}] * n / [meta] * n), so mutating one source's metadata leaked into all
the others. Each source now receives its own independent copy. Also removes
the now-redundant local workaround in FileToFileContent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@DivyaNarahari97
DivyaNarahari97 requested a review from a team as a code owner July 21, 2026 21:12
@DivyaNarahari97
DivyaNarahari97 requested review from anakin87 and removed request for a team July 21, 2026 21:12
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

@DivyaNarahari97 is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @DivyaNarahari97, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from anakin87 July 21, 2026 22:36
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Jul 21, 2026
@HaystackBot
HaystackBot marked this pull request as draft July 21, 2026 22:36
@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @DivyaNarahari97, just a friendly reminder: this PR is still in draft because the Contributor License Agreement (CLA) hasn't been signed yet. We'd love to review your contribution! Please sign the CLA via the link in the license/cla check, and this PR will automatically be marked ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-pending PR is in draft until the contributor signs the CLA topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants