Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SentenceTransformersDocumentEmbedder supports config_kwargs #8433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Oct 2, 2024

Related Issues

How did you test it?

  • ran tests locally and on CI

Notes for reviwer

Checklist

@github-actions github-actions bot added type:documentation Improvements on the docs topic:tests labels Oct 2, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11141801911

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 90.301%

Files with Coverage Reduction New Missed Lines %
components/embedders/sentence_transformers_document_embedder.py 2 96.72%
Totals Coverage Status
Change from base Build 11127612635: 0.001%
Covered Lines: 7458
Relevant Lines: 8259

💛 - Coveralls

@davidsbatista davidsbatista marked this pull request as ready for review October 2, 2024 10:03
@davidsbatista davidsbatista requested review from a team as code owners October 2, 2024 10:03
@davidsbatista davidsbatista requested review from dfokina, Amnah199 and julian-risch and removed request for a team October 2, 2024 10:03
@julian-risch julian-risch changed the title feat: SentenceTransformerEmbedder supports config_kwargs feat: SentenceTransformerDocumentEmbedder supports config_kwargs Oct 2, 2024
@julian-risch julian-risch changed the title feat: SentenceTransformerDocumentEmbedder supports config_kwargs feat: SentenceTransformersDocumentEmbedder supports config_kwargs Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing config_kwargs in sentence_transformers component
2 participants