-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: MarkdownHeaderSplitter #9660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: MarkdownHeaderSplitter #9660
Conversation
|
@OGuggenbuehl definitely looks like an interesting approach! I've left an initial set of comments, but to further review I'd appreciate if you could add a set of tests like the ones we have for the This will help me be able to review the actual algorithm for splitting since it's easier to understand with examples. |
61a8396 to
bcbbf9a
Compare
|
Thanks for your continued work on this @OGuggenbuehl! Some general comments. Could you:
|
Pull Request Test Coverage Report for Build 19575164151Details
💛 - Coveralls |
…dated page number
Co-authored-by: Sebastian Husch Lee <[email protected]>
Co-authored-by: Sebastian Husch Lee <[email protected]>
Co-authored-by: Sebastian Husch Lee <[email protected]>
Co-authored-by: Sebastian Husch Lee <[email protected]>
minor commenting
70e46d4 to
c7264e6
Compare
|
@sjrl mypy has started complaining about a file that is unrelated to this pr: I assume this is an upstream issue and I can simply rebase after it's been fixed upstream? |
Proposed Changes:
Implement MarkdownHeaderSplitter to split Documents written in .md based on their headers
How did you test it?
unit tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.