fix: avoid ZeroDivisionError in compute_elastic_config return_microbatch path#8162
Open
Solaris-star wants to merge 1 commit into
Open
Conversation
…tch path For elasticity versions other than 0.2, return_microbatch=True with the default world_size=0 divided by zero. Require a positive world_size (or WORLD_SIZE) and raise ElasticityConfigError instead. Fixes deepspeedai#8156 Signed-off-by: Solaris-star <820622658@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
compute_elastic_config(..., return_microbatch=True)on elasticity version0.1(and any non-0.2version) divided by the defaultworld_size=0and raised a bareZeroDivisionError. Version0.2already has a dedicated microbatch path that does not need this division.Changes
world_sizeargument or numericWORLD_SIZEenv before selecting a microbatch.ElasticityConfigErrorwith a clear message instead ofZeroDivisionError.world_sizeagainstvalid_gpusbefore dividing.world_size=64.Related issue
Fixes #8156
Tests
test_return_microbatch_requires_world_size_v01test_return_microbatch_with_world_size_v01