Skip to content

NVMe write warning#8164

Open
sfc-gh-truwase wants to merge 3 commits into
masterfrom
sfc-gh-truwase/nvme_warning
Open

NVMe write warning#8164
sfc-gh-truwase wants to merge 3 commits into
masterfrom
sfc-gh-truwase/nvme_warning

Conversation

@sfc-gh-truwase

@sfc-gh-truwase sfc-gh-truwase commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator
  • Add write endurance warning
  • Move UTs

Signed-off-by: tunji-ruwase_snow <tunji.ruwase@snowflake.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

# Copyright (c) Microsoft Corporation.

P1 Badge Exclude GDS test from v1 CI runners

After this rename, tests/unit/v1/nvme/test_gds.py is picked up by workflows that run the whole v1 suite, but aws-torch-latest.yml still invokes pytest ... tests/unit/v1/ without any ignore, while the full AWS workflow explicitly ignores this same file because the runner has no GPUDirect Storage support. On CUDA images where GDSBuilder.is_compatible() finds libcufile, this will run the GDS tests on unsupported storage and fail CI; add the same ignore/skip handling to the v1 runners before moving this test under unit/v1.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

sfc-gh-truwase and others added 2 commits July 21, 2026 18:03
Signed-off-by: sfc-gh-truwase <tunji.ruwase@snowflake.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@stas00 stas00 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Tunji

I'd also add a note to the online docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants