NVMe write warning#8164
Conversation
Signed-off-by: tunji-ruwase_snow <tunji.ruwase@snowflake.com>
There was a problem hiding this comment.
💡 Codex Review
After this rename, tests/unit/v1/nvme/test_gds.py is picked up by workflows that run the whole v1 suite, but aws-torch-latest.yml still invokes pytest ... tests/unit/v1/ without any ignore, while the full AWS workflow explicitly ignores this same file because the runner has no GPUDirect Storage support. On CUDA images where GDSBuilder.is_compatible() finds libcufile, this will run the GDS tests on unsupported storage and fail CI; add the same ignore/skip handling to the v1 runners before moving this test under unit/v1.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
stas00
left a comment
There was a problem hiding this comment.
Looking good, Tunji
I'd also add a note to the online docs
Uh oh!
There was an error while loading. Please reload this page.