Skip to content

Fix Comet samples_log_interval docstring typo #8400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YeonwooSung wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix Comet samples_log_interval docstring typo #8400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee0893f
Fix Comet samples_log_interval docstring typo
YeonwooSung Sep 3, 2026
37960d7
Merge branch 'master' into docs/fix-comet-samples-log-interval-typo
YeonwooSung Sep 3, 2026
6f7c5ce
Merge branch 'master' into docs/fix-comet-samples-log-interval-typo
YeonwooSung Sep 4, 2026
2b4c18a
Merge branch 'master' into docs/fix-comet-samples-log-interval-typo
YeonwooSung Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/monitor/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class CometConfig(DeepSpeedConfigModel):
""" Whether logging to Comet is enabled. Requires `comet_ml` package is installed. """

samples_log_interval: int = 100
""" Metrics will be submitted to Comet after processing every `samples_log_intervas` samples"""
""" Metrics will be submitted to Comet after processing every `samples_log_interval` samples"""
Comment thread
YeonwooSung marked this conversation as resolved.

project: Optional[str] = None
"""
Expand Down
2 changes: 1 addition & 1 deletion docs/_pages/config-json.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,7 +1681,7 @@ Example of <i>**wandb**</i> configuration:
| enabled | Whether logging to [Comet](https://www.comet.com/site/) is enabled. | `false` |
| workspace | Comet workspace name. | `None` |
| project | Comet project name. | `None` |
| samples_log_interval | Metrics will be submitted to Comet after processing every `samples_log_intervas` samples. | `100` |
| samples_log_interval | Metrics will be submitted to Comet after processing every `samples_log_interval` samples. | `100` |
| experiment_name | The name for comet experiment to be used for logging. | `None` |
| api_key | Comet API key. It's not recommended to save the Comet API Key in code. | `None` |
| experiment_key | The key for comet experiment to be used for logging. Must be an alphanumeric string whose length is between 32 and 50 characters. | `None` |
Expand Down
Loading