op_builder: use C++20 for nvcc on CUDA 13+ - #8422
Merged
Merged
Conversation
nvcc_args() only passes -std=c++20 when CUDA is 12.5+, so on CUDA 13.x it falls back to -std=c++17. PyTorch >= 2.12 headers require C++20, so CUDA op builds fail with '#error C++20 or later compatible compiler is required to use PyTorch'. cxx_args() already handles torch >= 2.12; extend the nvcc-side condition to cover CUDA 13+ as well. Signed-off-by: Frank Tin <frank@bheu.net>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11250f027b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hwchen2017
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CUDAOpBuilder.nvcc_args()only passes-std=c++20to nvcc when CUDA is 12.5+; on CUDA 13.x it falls back to-std=c++17. PyTorch >= 2.12 headers require C++20, so building DeepSpeed CUDA ops against CUDA 13 + torch >= 2.12 fails:Note that
cxx_args()already selects-std=c++20for torch >= 2.12 (see #8238), so only the nvcc path is broken.Fix
Extend the C++20 condition in
nvcc_args()to also cover CUDA 13+:Verification
Built DeepSpeed from source (
DS_BUILD_OPS=1 pip install .) with CUDA 13.3, PyTorch 2.14.0, gcc-13: the build fails before this change with the errors above and completes successfully with it.