Conversation
delock
force-pushed
the
pr-f-autocast-cpu
branch
from
September 17, 2026 00:32
71e6b84 to
c162ba4
Compare
bf16_required_version_check() requires torch >= 1.10, CUDA >= 11 and NCCL >= 2.10.3, so on the cpu accelerator, where bf16 collectives run over gloo/ccl and none of those dependencies exist, the check always fails and every bf16 test is skipped, about 40 call sites across 15 files. test_zero_autocast is worse off: it raises instead of skipping, so each case counts as a failure. Exempt the cpu accelerator inside the check itself so all call sites benefit: on cpu only the accelerator's own bf16 support is required. Every other accelerator evaluates the exact original floors, and test_zero_autocast now skips like every other caller instead of raising. Signed-off-by: Guokai Ma <guokai.ma@intel.com>
delock
force-pushed
the
pr-f-autocast-cpu
branch
from
September 17, 2026 00:39
c162ba4 to
baf0caa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bf16_required_version_check()(tests/unit/util.py) requires torch >= 1.10, CUDA >= 11.0 and NCCL >= 2.10.3. On the cpu accelerator, bf16 collectives run over gloo/ccl and none of those transport dependencies exist, so the check always returns False and every bf16 test is skipped — about 40 call sites across 15 files.test_zero_autocast.pyis worse off: it raises instead of skipping, so each of its cases counts as a failure (24 on the multi-rank CPU run in #8381).This PR scopes the version floors inside the check itself:
is_bf16_supported()) is required — the torch/CUDA/NCCL floors are transport dependencies that gloo/ccl does not havecpu_acceleratoris False so the expression is bit-identical to before, and the npu/hpu/xpu exemption branches are untouchedtest_zero_autocast.py: the bf16 gate goes back to the bare call every other caller uses, and skips instead of raisingThe hardcoded
init_distributed(dist_backend='nccl')in the same test is deliberately left alone: it is a no-op (the harness already initialized the process group,comm.py:838-839), and deriving the backend per accelerator would change behavior on non-cuda accelerators (npu/hpu resolve to hccl etc.). The baselineDDP(device_ids=[i])pinning is left for a follow-up (#8399 fixed the same pattern elsewhere).Validation (executed on real hardware)
bf16_required_version_check()on cpu returnsFalsebefore,Trueafter. Note:CPU_Accelerator.is_bf16_supported()is currently a stub that always returns True, so the cpu path does not gate on the hardware's bf16 instructions — giving it a real capability probe is left as a follow-upcpu_accelerator == Falsethe new expression reduces exactly to the originalA and C and N and PSibling PRs from the same series: #8397, #8398, #8399, #8407, #8409. Exposed by the
LOCAL_SIZE=4multi-rank CPU run in #8381.