Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update weights_only due to change in default in torch 2.6+ #957

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update weights_only due to change in default in torch 2.6+ #957

merged 2 commits into from
Feb 12, 2025

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Feb 10, 2025 •
edited
Loading

Bug discovered when updating DeepSpeed runners to cuda 12.4 (which allows the download of torch 2.6+) means we need to make changes to this.

@loadams loadams requested a review from tjruwase as a code owner February 10, 2025 22:16
@loadams loadams force-pushed the loadams/torch-load-weights-only branch from 196d624 to 5668561 Compare February 10, 2025 22:16
@loadams
formatting
37f60e2 
Signed-off-by: Logan Adams <[email protected]>
@loadams loadams requested a review from jeffra February 10, 2025 22:23
@tjruwase tjruwase merged commit 83757d9 into master Feb 12, 2025
2 checks passed
@loadams loadams deleted the loadams/torch-load-weights-only branch February 12, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@lekurile lekurile lekurile approved these changes

@jeffra jeffra Awaiting requested review from jeffra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loadams @tjruwase @lekurile