feat(serve-htmx): add HtmlContent terminal send, decouple from base-template#32
Merged
feat(serve-htmx): add HtmlContent terminal send, decouple from base-template#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
HtmlContent— a@FunctionalInterfaceinserve-templatethat produces a rendered HTML string — and wires it intoHtmxResponse.send(HtmlContent)as the terminal step of the fluent chain. This removes the direct dependency onbase.build'sbase-templatemodule that was introduced when thesendoverload was first drafted.serve-htmxnow depends onserve-template(transitive, soHtmlContentis on callers' module path automatically) and is otherwise ignorant of any specific template engine. Callers using base-template templates adapt with a one-liner() -> { var out = new HtmlOut(); t.render(out); return out.toString(); }, which belongs in the module that knows about that engine. Tests cover the status/content-type/body contract and the preservation of HX-* headers set before the terminalsend.