fix: misc security and correctness fixes#65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response.removeHeader(String)added as a default no-op;HttpResponseoverrides it viagetResponseHeaders().remove();SecurityHeadersMiddlewareuses it instead of setting headers to""so suppressed headers are actually absent from responsescontainsTraversalcheck removed fromStaticFileHandler—Path.normalize()resolves..before thecontains("..")test, making it dead code; the real protection is thestartsWithguard inhandleDirectoryBasicAuthStrategyconstructor rejects realm values containing",\r, or\nwithIllegalArgumentExceptionto preventWWW-Authenticateheader injectionGraphiQlHandler.escapeJs()helper added; escapes\,',\r,\nbefore substituting the endpoint into the JS string literalChromeDevToolsHandler.forWorkspace()logs aWARNINGat call time noting that it exposes the absolute filesystem pathJsonErrorHandler.statusText()extended with 413 and 429;stripControlChars()added and applied toHttpExceptionmessages to prevent CRLF injection in JSON error bodiesSseEventcompact constructor validatesdatais non-nullAuthStrategy.anyOfchanged from a lambda to an anonymous class that overrideschallenge()to join all delegates' challenges with", "so the compositeWWW-Authenticateheader reflects all active schemesLspTransport.tcp()catchesSocketExceptionfromaccept()and breaks cleanly; the enclosing try-with-resources releases theServerSocket