Skip to content

Conversation

@AmberFryar
Copy link
Contributor

@AmberFryar AmberFryar commented Jan 15, 2026

Description

Added warning log to src/cli/index.ts warning users not to use the default admin role in production. Expanded the docs to also include a callout to warn users of the risk of admin level permissions. Corrected a typo in src/cli/dev.ts log error message.
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@AmberFryar AmberFryar requested a review from a team as a code owner January 15, 2026 21:01
@AmberFryar AmberFryar linked an issue Jan 15, 2026 that may be closed by this pull request
2 tasks
@github-project-automation github-project-automation bot moved this to 👀 In review in Pepr Project Board Jan 15, 2026
@cmwylie19 cmwylie19 changed the title chore: added log warning and updated docs for default admin mode fix: added log warning and updated docs for default admin mode Jan 15, 2026
@cmwylie19 cmwylie19 merged commit d4675a6 into main Jan 15, 2026
98 of 99 checks passed
@cmwylie19 cmwylie19 deleted the 2879-overly-permissive-rbac-clusterrole-in-admin-mode---need-to-warn-users branch January 15, 2026 21:09
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (92a8510) to head (d474519).
⚠️ Report is 110 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2883       +/-   ##
==========================================
- Coverage   85.35%       0   -85.36%     
==========================================
  Files          95       0       -95     
  Lines        6478       0     -6478     
  Branches      782       0      -782     
==========================================
- Hits         5529       0     -5529     
+ Misses        936       0      -936     
+ Partials       13       0       -13     

see 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

🎉 This PR is included in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Overly Permissive RBAC ClusterRole in Admin Mode - Need to warn users

3 participants