chore(deps): upgrade to go 1.24 #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noxsios
changed the title
Contributor
Author
|
Had to |
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
Signed-off-by: Harry Randazzo <[email protected]>
AustinAbro321
approved these changes
Apr 21, 2025
Contributor
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
LGTM, distribution/distribution is only used in tests so importers won't pick up the dependency at a specific commit anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI is currently stuck due to vulnerabilities in old dependencies + some needed
go mod tidy. Checked Zarf (only importer this repo currently cares about) and it is on Go 1.24.x, so upgrading to Go 1.24.0 should not introduce any breaking changes.Evidence: