ci: excluding portal package from registry1 flavor CI tests#2703
Conversation
Greptile SummaryThis PR extends existing CI patterns to exclude the
Confidence Score: 5/5All changes are additive CI configuration tweaks that exclude portal from registry1 flavor tests, matching patterns already proven in other workflows. The conditional --set EXCLUDED_PACKAGES= pattern is already used identically in publish.yaml and test.yaml; the empty-string case is handled by the default: "" declaration in tasks/test.yaml and the grep-based filter logic. Adding portal.uds.dev to the tenant-gateway host entry is a straightforward additive change with no risk of breaking existing workflows. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix: adding portal url to setup-hosts ta..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Adjusts CI workflow invocations of UDS test tasks so the portal package is excluded when running the registry1 flavor, aligning CI with the fact that portal is not built/deployed for registry1.
Changes:
- Pass
EXCLUDED_PACKAGES=portalto non-k3d test runs forregistry1in the RKE2 and EKS workflows. - Pass
EXCLUDED_PACKAGES=portalto HA k3d install/upgrade tests forregistry1. - Extend the AKS workflow’s exclusions to also skip
portalonregistry1(in addition tometrics-server).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/test-rke2.yaml | Adds EXCLUDED_PACKAGES override for registry1 flavor during non-k3d tests. |
| .github/workflows/test-k3d-ha.yaml | Adds EXCLUDED_PACKAGES override for registry1 flavor during HA install/upgrade tests. |
| .github/workflows/test-eks.yaml | Adds EXCLUDED_PACKAGES override for registry1 flavor during non-k3d tests. |
| .github/workflows/test-aks.yaml | Expands excluded packages for registry1 flavor to include portal. |
|
@greptile review |
## Description Excludes the `portal` package from Private PKI CI when running the `registry1` flavor. This applies the same registry1 workaround used by the other CI jobs in #2703, where `portal` is skipped because it is not supported for registry1 validation. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-core/blob/main/CONTRIBUTING.md) followed
Description
Other CI adjustments to exclude portal package from registry1 flavor tests
Related Issue
Related to CORE-536
Type of change
Steps to Validate
Will need to validate IaC tests following weekend
Checklist before merging