Skip to content

ci: excluding portal package from registry1 flavor CI tests#2703

Merged
briantwatson merged 3 commits into
mainfrom
ci/exclude-portal-registry1-flavors
May 28, 2026
Merged

ci: excluding portal package from registry1 flavor CI tests#2703
briantwatson merged 3 commits into
mainfrom
ci/exclude-portal-registry1-flavors

Conversation

@briantwatson

Copy link
Copy Markdown
Contributor

Description

Other CI adjustments to exclude portal package from registry1 flavor tests

Related Issue

Related to CORE-536

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

Will need to validate IaC tests following weekend

Checklist before merging

Copilot AI review requested due to automatic review settings May 28, 2026 13:51
@briantwatson briantwatson requested a review from a team as a code owner May 28, 2026 13:51
@greptile-apps

greptile-apps Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends existing CI patterns to exclude the portal package from registry1 flavor tests across all cloud-provider and HA test workflows (AKS, EKS, RKE2, k3d-HA). It mirrors the same conditional-exclusion logic already in use in test.yaml and publish.yaml. A portal.uds.dev host entry is also added to the tenant-gateway section of setup-hosts in tasks/utils.yaml.

  • Workflow updates (4 files): Each CI workflow gains --set EXCLUDED_PACKAGES=${{ matrix.flavor == 'registry1' && 'portal' || '' }} (or appends portal to the existing metrics-server exclusion for AKS). For non-registry1 flavors the value is empty, which is safe given the default: \"\" in tasks/test.yaml.
  • Host setup (tasks/utils.yaml): portal.uds.dev is appended to the tenant-gateway /etc/hosts line so local DNS resolution works for portal during non-excluded test runs.

Confidence Score: 5/5

All changes are additive CI configuration tweaks that exclude portal from registry1 flavor tests, matching patterns already proven in other workflows.

The conditional --set EXCLUDED_PACKAGES= pattern is already used identically in publish.yaml and test.yaml; the empty-string case is handled by the default: "" declaration in tasks/test.yaml and the grep-based filter logic. Adding portal.uds.dev to the tenant-gateway host entry is a straightforward additive change with no risk of breaking existing workflows.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/test-aks.yaml Adds FLAVOR pass-through and conditionally appends portal to the already-present metrics-server exclusion for registry1 flavor.
.github/workflows/test-eks.yaml Adds FLAVOR and EXCLUDED_PACKAGES conditional for registry1; pattern matches publish.yaml and test.yaml.
.github/workflows/test-rke2.yaml Identical change to test-eks.yaml; adds FLAVOR and portal exclusion for registry1.
.github/workflows/test-k3d-ha.yaml Applies portal exclusion to both install and upgrade HA test steps.
tasks/utils.yaml Adds portal.uds.dev to the tenant-gateway hosts line for correct DNS resolution.

Reviews (2): Last reviewed commit: "fix: adding portal url to setup-hosts ta..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts CI workflow invocations of UDS test tasks so the portal package is excluded when running the registry1 flavor, aligning CI with the fact that portal is not built/deployed for registry1.

Changes:

  • Pass EXCLUDED_PACKAGES=portal to non-k3d test runs for registry1 in the RKE2 and EKS workflows.
  • Pass EXCLUDED_PACKAGES=portal to HA k3d install/upgrade tests for registry1.
  • Extend the AKS workflow’s exclusions to also skip portal on registry1 (in addition to metrics-server).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/test-rke2.yaml Adds EXCLUDED_PACKAGES override for registry1 flavor during non-k3d tests.
.github/workflows/test-k3d-ha.yaml Adds EXCLUDED_PACKAGES override for registry1 flavor during HA install/upgrade tests.
.github/workflows/test-eks.yaml Adds EXCLUDED_PACKAGES override for registry1 flavor during non-k3d tests.
.github/workflows/test-aks.yaml Expands excluded packages for registry1 flavor to include portal.

Comment thread .github/workflows/test-rke2.yaml Outdated
Comment thread .github/workflows/test-eks.yaml Outdated
Comment thread .github/workflows/test-aks.yaml Outdated
Comment thread .github/workflows/test-aks.yaml Outdated
@briantwatson

Copy link
Copy Markdown
Contributor Author

@greptile review

@briantwatson briantwatson merged commit 611ece3 into main May 28, 2026
46 of 52 checks passed
@briantwatson briantwatson deleted the ci/exclude-portal-registry1-flavors branch May 28, 2026 19:06
chance-coleman added a commit that referenced this pull request May 28, 2026
## Description
Excludes the `portal` package from Private PKI CI when running the
`registry1` flavor.
This applies the same registry1 workaround used by the other CI jobs in
#2703, where `portal` is skipped because it is not supported for
registry1 validation.


## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-core/blob/main/CONTRIBUTING.md)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants