fix: rm vitest setup and js start local-network

[wei3erHase]

🤖 Linear

Closes AZT-XXX

Description

Summary by CodeRabbit

• Documentation

  • Added Development section to README with prerequisites and testing instructions.

• Tests

  • Updated test configuration to use local network setup instead of automated sandbox initialization.
  • Introduced default local network port configuration and node URL resolution.

[coderabbitai]

Caution

Review failed

Failed to post review comments

Warning

Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories.

Walkthrough

PR removes automated sandbox lifecycle management infrastructure (start-sandbox.ts, vitest.setup.ts) and vitest globalSetup configuration, replacing them with local network testing approach. Adds node URL resolution utilities and updates documentation for local development.

Changes

Cohort / File(s)	Summary
Sandbox Infrastructure Removal scripts/start-sandbox.ts, vitest.setup.ts	Deleted automated sandbox setup lifecycle. Removed startSandbox() function that spawned Aztec CLI process and monitored readiness, and removed global setup hook that executed sandbox initialization before tests.
Local Network Utilities src/ts/test/utils.ts	Added LOCAL_NETWORK_DEFAULT_PORT constant (8080), DEFAULT_NODE_URL construction, and getNodeUrl() helper function for centralized node URL resolution via NODE_URL env var or default fallback.
Configuration Updates .coderabbit.yaml, vitest.config.ts	Removed vitest globalSetup option and updated CI/CD workflow notes from sandbox-based to local network-based testing. Updated comment references from "sandbox tests" to "local network tests".
Documentation README.md	Added Development section with prerequisites, test execution instructions, benchmark commands, and NODE_URL override documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore: v4.0.0-devnet.1-patch.0 #264: Directly inverse changes—adds start-sandbox.ts, vitest.setup.ts, and globalSetup configuration that this PR removes.

Suggested reviewers

• 0xShaito
• ilpepepig

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete with only template placeholders filled; the actual changes and rationale are entirely missing.	Provide a detailed description explaining why the sandbox setup was removed, what the local-network approach offers, and any migration implications for developers.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main changes: removing vitest setup and switching to local-network mode instead of sandbox.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/vitest-setup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Benchmark Comparison

CPU	Cores	RAM	Arch
AMD EPYC 7763 64-Core Processor	16	63 GiB	x64

Contract: escrow

	Function	Gates			DA Gas			L2 Gas			Proving Time (ms)
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	(partial) withdraw	551,361	551,361		22,016	22,016		512	512		7,056	7,092	+36 (+0.5%)
⚪	withdraw	551,361	551,361		11,776	11,776		512	512		7,070	7,088	+18 (+0.3%)
⚪	withdraw_nft	521,153	521,153		11,776	11,776		512	512		6,902	6,976	+74 (+1.1%)

Contract: logic

	Function	Gates			DA Gas			L2 Gas			Proving Time (ms)
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	get_escrow	413,263	413,263		1,024	1,024		512	512		6,018	6,016	-2 (-0.0%)
⚪	secret_keys_to_public_keys	408,340	408,340		1,024	1,024		512	512		5,940	5,987	+47 (+0.8%)
⚪	share_escrow	405,898	405,898		11,264	11,264		512	512		5,932	6,046	+114 (+1.9%)

Contract: nft

	Function	Gates			DA Gas			L2 Gas			Proving Time (ms)
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	burn_private	460,583	460,583		2,560	2,560		132,265	132,265		6,346	6,379	+33 (+0.5%)
⚪	burn_public	346,521	346,521		3,072	3,072		139,708	139,708		5,408	5,399	-9 (-0.2%)
⚪	mint_to_private	458,872	458,872		12,288	12,288		120,770	120,770		6,448	6,438	-10 (-0.2%)
⚪	mint_to_public	346,521	346,521		3,072	3,072		143,932	143,932		5,427	5,498	+71 (+1.3%)
⚪	transfer_private_to_private	411,588	411,588		11,776	11,776		512	512		6,030	6,039	+9 (+0.1%)
⚪	transfer_private_to_public	460,586	460,586		2,560	2,560		127,336	127,336		6,356	6,421	+65 (+1.0%)
⚪	transfer_public_to_private	455,437	455,437		12,288	12,288		121,079	121,079		6,368	6,410	+42 (+0.7%)
⚪	transfer_public_to_public	346,521	346,521		2,048	2,048		102,023	102,023		5,422	5,454	+32 (+0.6%)

Contract: token

	Function	Gates			DA Gas			L2 Gas			Proving Time (ms)
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	burn_private	479,299	479,299		12,800	12,800		146,878	146,878		6,532	6,534	+2 (+0.0%)
⚪	burn_public	346,521	346,521		3,072	3,072		136,102	136,102		5,480	5,504	+24 (+0.4%)
⚪	initialize_transfer_commitment	424,338	424,338		11,264	11,264		512	512		6,066	6,122	+56 (+0.9%)
⚪	mint_to_private	458,815	458,815		12,288	12,288		115,835	115,835		6,360	6,443	+83 (+1.3%)
⚪	mint_to_public	346,521	346,521		3,072	3,072		144,298	144,298		5,431	5,538	+107 (+2.0%)
⚪	transfer_private_to_commitment	444,035	444,035		13,824	13,824		512	512		6,183	6,200	+17 (+0.3%)
⚪	transfer_private_to_private	441,790	441,790		22,016	22,016		512	512		6,148	6,202	+54 (+0.9%)
⚪	transfer_private_to_public	479,375	479,375		12,800	12,800		149,749	149,749		6,515	6,530	+15 (+0.2%)
⚪	transfer_private_to_public_with_commitment	509,042	509,042		23,040	23,040		180,549	180,549		6,699	6,782	+83 (+1.2%)
⚪	transfer_public_to_commitment	346,521	346,521		4,608	4,608		132,362	132,362		5,433	5,485	+52 (+1.0%)
⚪	transfer_public_to_private	455,469	455,469		12,288	12,288		119,030	119,030		6,363	6,414	+51 (+0.8%)
⚪	transfer_public_to_public	346,521	346,521		3,072	3,072		138,790	138,790		5,491	5,505	+14 (+0.3%)

Contract: tokenized_vault

	Function	Gates			DA Gas			L2 Gas			Proving Time (ms)
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	deposit_private_to_private	712,559	712,559		14,336	14,336		295,387	295,387		8,651	8,714	+63 (+0.7%)
⚪	deposit_private_to_private_exact	742,301	742,301		24,576	24,576		326,556	326,556		8,888	8,943	+55 (+0.6%)
⚪	deposit_private_to_public	712,296	712,296		5,120	5,120		314,505	314,505		8,676	8,699	+23 (+0.3%)
⚪	deposit_public_to_private	455,479	455,479		15,360	15,360		362,177	362,177		6,490	6,510	+20 (+0.3%)
⚪	deposit_public_to_private_exact	485,251	485,251		25,600	25,600		393,508	393,508		6,694	6,699	+5 (+0.1%)
⚪	deposit_public_to_public	346,521	346,521		6,144	6,144		379,762	379,762		5,562	5,556	-6 (-0.1%)
⚪	issue_private_to_private_exact	899,814	899,814		24,576	24,576		326,832	326,832		10,010	10,097	+87 (+0.9%)
⚪	issue_private_to_public_exact	899,574	899,574		15,360	15,360		346,277	346,277		10,290	10,302	+12 (+0.1%)
⚪	issue_public_to_private	455,470	455,470		15,360	15,360		363,098	363,098		6,527	6,509	-18 (-0.3%)
⚪	issue_public_to_public	346,521	346,521		6,144	6,144		380,167	380,167		5,548	5,571	+23 (+0.4%)
⚪	redeem_private_to_private_exact	776,472	776,472		24,064	24,064		296,101	296,101		8,922	8,967	+45 (+0.5%)
⚪	redeem_private_to_public	479,375	479,375		4,608	4,608		285,086	285,086		6,421	6,437	+16 (+0.2%)
⚪	redeem_public_to_private_exact	752,144	752,144		24,576	24,576		304,183	304,183		8,785	8,847	+62 (+0.7%)
⚪	redeem_public_to_public	346,521	346,521		5,120	5,120		291,800	291,800		5,398	5,415	+17 (+0.3%)
⚪	withdraw_private_to_private	595,855	595,855		13,824	13,824		264,251	264,251		7,409	7,477	+68 (+0.9%)
⚪	withdraw_private_to_private_exact	615,681	615,681		24,064	24,064		295,663	295,663		7,527	7,576	+49 (+0.7%)
⚪	withdraw_private_to_public_exact	499,220	499,220		14,848	14,848		316,546	316,546		6,584	6,574	-10 (-0.2%)
⚪	withdraw_public_to_private	571,676	571,676		14,336	14,336		271,925	271,925		7,283	7,326	+43 (+0.6%)
⚪	withdraw_public_to_public	346,521	346,521		5,120	5,120		291,683	291,683		5,424	5,449	+25 (+0.5%)