Skip to content

feat: benchmarking script #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 65 commits into from
Closed

feat: benchmarking script #63

wants to merge 65 commits into from

Conversation

xorsal
Copy link
Collaborator

@xorsal xorsal commented Mar 21, 2025

No description provided.

xorsal and others added 29 commits March 20, 2025 08:34
- change `U128` to `u128`
- use u128 operations
- use `PartialUintNote` instead of `Field` for hiding points
- use `u128` instead of `U128`
Skipped two tests because I'm unable to understand what seems to be the
problem with them
Solves #34 by unconstraining the library method (it gets constrained
anyways because its being executed from a constrained method)
`Assertion failed: unauthorized 'true, authorized'`
I changed the test a bit, but I don't really understand what seems to be
the problem
we don't care about their gate-counting measurements
but we will use them to measure gas later!
@xorsal xorsal force-pushed the feat/benchmarking-script branch from cabaa7c to eae456f Compare March 25, 2025 15:48
Copy link

Benchmark Comparison

Comparison Threshold: 5%

Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed

Contract: token_contract

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
BENCHMARK_RUNNER_ERROR 0 0 - 0 0 - 0 0 -

Copy link

Benchmark Comparison

Comparison Threshold: 5%

Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed

Contract: token_contract

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
BENCHMARK_RUNNER_ERROR 0 0 - 0 0 - 0 0 -

Copy link

Benchmark Comparison

Comparison Threshold: 5%

Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed

Contract: token_contract

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
BENCHMARK_RUNNER_ERROR 0 0 - 0 0 - 0 0 -

Copy link

Benchmark Comparison

Contract: token

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
burn_private 325,168 325,168 13,517 13,517 53,473 53,473
burn_public 208,476 208,476 2,253 2,253 71,090 71,090
mint_to_private 320,811 320,811 12,954 12,954 47,489 47,489
mint_to_public 208,476 208,476 2,253 2,253 71,866 71,866
transfer_private_to_private 331,983 331,983 24,218 24,218 20,909 20,909
transfer_private_to_public 325,248 325,248 13,517 13,517 70,435 70,435
transfer_private_to_public_with_commitment 350,224 350,224 24,781 24,781 104,237 104,237
transfer_public_to_private 316,576 316,576 12,954 12,954 64,609 64,609
transfer_public_to_public 208,476 208,476 2,253 2,253 88,498 88,498

Copy link

Benchmark Comparison

Contract: token

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
burn_private 325,168 325,168 13,517 13,517 53,473 53,473
burn_public 208,476 208,476 2,253 2,253 71,090 71,090
mint_to_private 320,811 320,811 12,954 12,954 47,489 47,489
mint_to_public 208,476 208,476 2,253 2,253 71,866 71,866
transfer_private_to_private 331,983 331,983 24,218 24,218 20,909 20,909
transfer_private_to_public 325,248 325,248 13,517 13,517 70,435 70,435
transfer_private_to_public_with_commitment 350,224 350,224 24,781 24,781 104,237 104,237
transfer_public_to_private 316,576 316,576 12,954 12,954 64,609 64,609
transfer_public_to_public 208,476 208,476 2,253 2,253 88,498 88,498

Copy link

Benchmark Comparison

Contract: token

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
burn_private 325,168 325,168 13,517 13,517 53,473 53,473
burn_public 208,476 208,476 2,253 2,253 71,090 71,090
mint_to_private 320,811 320,811 12,954 12,954 47,489 47,489
mint_to_public 208,476 208,476 2,253 2,253 71,866 71,866
transfer_private_to_private 331,983 331,983 24,218 24,218 20,909 20,909
transfer_private_to_public 325,248 325,248 13,517 13,517 70,435 70,435
transfer_private_to_public_with_commitment 350,224 350,224 24,781 24,781 104,237 104,237
transfer_public_to_private 316,576 316,576 12,954 12,954 64,609 64,609
transfer_public_to_public 208,476 208,476 2,253 2,253 88,498 88,498

Copy link

Benchmark Comparison

Contract: token

Function Gates DA Gas L2 Gas
Status Base PR Diff Base PR Diff Base PR Diff
burn_private 325,168 325,168 13,517 13,517 53,473 53,473
burn_public 208,476 208,476 2,253 2,253 71,090 71,090
mint_to_private 320,811 320,811 12,954 12,954 47,489 47,489
mint_to_public 208,476 208,476 2,253 2,253 71,866 71,866
transfer_private_to_private 331,983 331,983 24,218 24,218 20,909 20,909
transfer_private_to_public 325,248 325,248 13,517 13,517 70,435 70,435
transfer_private_to_public_with_commitment 350,224 350,224 24,781 24,781 104,237 104,237
transfer_public_to_private 316,576 316,576 12,954 12,954 64,609 64,609
transfer_public_to_public 208,476 208,476 2,253 2,253 88,498 88,498

@0xmoebius
Copy link
Collaborator

replaced by #85

@0xmoebius 0xmoebius closed this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants