-
Notifications
You must be signed in to change notification settings - Fork 2
feat: benchmarking script #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change `U128` to `u128` - use u128 operations - use `PartialUintNote` instead of `Field` for hiding points
- use `u128` instead of `U128`
Skipped two tests because I'm unable to understand what seems to be the problem with them
Solves #34 by unconstraining the library method (it gets constrained anyways because its being executed from a constrained method)
`Assertion failed: unauthorized 'true, authorized'` I changed the test a bit, but I don't really understand what seems to be the problem
we don't care about their gate-counting measurements but we will use them to measure gas later!
cabaa7c
to
eae456f
Compare
Benchmark ComparisonComparison Threshold: 5% Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed Contract: token_contract
|
Benchmark ComparisonComparison Threshold: 5% Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed Contract: token_contract
|
Benchmark ComparisonComparison Threshold: 5% Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed Contract: token_contract
|
Benchmark ComparisonContract: token
|
Benchmark ComparisonContract: token
|
Benchmark ComparisonContract: token
|
Benchmark ComparisonContract: token
|
replaced by #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.