feat: nft-contract #66
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daopunk
changed the title
xorsal
reviewed
Apr 1, 2025
There was a problem hiding this comment.
We shouldn't merge this PR here, but instead in defi-wonderland/aztec-extensions to keep the codebase as slim as possible while we finish developing the token standard (so we avoid increasing the amount of code to maintain).
things I'd change:
- Remove the event (seems it's not even used now!)
- Merge
adminandminters. A singlePublicImmutable<AztecAddress>should suffice - Function ordering: constructor, private, private internal, public, public internal, internal, view, contract libraries, unconstrained
- Rename "partial note" to "commitment"
- Extract AuthLibs functions, similarly to what we did in token_contract. Check
_validate_from_publicand_validate_minter. - Remove
authwit_cancel
Added natspec for refactored contract
Co-authored-by: shaito <[email protected]> Signed-off-by: daopunk <[email protected]>
Co-authored-by: shaito <[email protected]> Signed-off-by: daopunk <[email protected]>
refactored the logic in the nft contract to follow the patterns in the token contract and improve readability of "external" functions
closes AZT-158 --------- Co-authored-by: Weißer Hase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR:
ref:
https://linear.app/defi-wonderland/issue/AZT-134/nft-contract