Skip to content

Conversation

@0xiamflux
Copy link

@0xiamflux 0xiamflux commented Dec 23, 2025

  • Adds unit test for makeDCI function, ensures the right OPCM address is used depending on the Dev Flag.
  • Adds test cases for DeployOPChain.s.sol:
    • Tests for the requires in checkInput
    • Tests for enabled games on OPCM v2

Closes OPT-1384
Closes OPT-1348
Closes OPT-1344

@0xiamflux 0xiamflux requested a review from 0xniha December 23, 2025 16:39
@0xiamflux 0xiamflux self-assigned this Dec 23, 2025
@linear
Copy link

linear bot commented Dec 23, 2025

Copy link

@0xniha 0xniha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two extra comments:

  • We must remove the OpcmV2Impl arg from ImplementationContracts struct since is not used by DeployImplementations.
  • We should replace the hardcoded initBonds value associated to each Game Type (0.08 ether).

@0xiamflux
Copy link
Author

Two extra comments:

  • We must remove the OpcmV2Impl arg from ImplementationContracts struct since is not used by DeployImplementations.
  • We should replace the hardcoded initBonds value associated to each Game Type (0.08 ether).

Addressed the init bonds here. For the other one we will take no action as the argument is indeed used by the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants