forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 2
test: opcm2 deploy test #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xiamflux
wants to merge
10
commits into
sc-feat/opcm2-deploy-test-strat
Choose a base branch
from
test/opcm2-deploy-test-strat
base: sc-feat/opcm2-deploy-test-strat
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: opcm2 deploy test #782
0xiamflux
wants to merge
10
commits into
sc-feat/opcm2-deploy-test-strat
from
test/opcm2-deploy-test-strat
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xniha
reviewed
Dec 26, 2025
0xniha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two extra comments:
- We must remove the
OpcmV2Implarg fromImplementationContractsstruct since is not used byDeployImplementations. - We should replace the hardcoded
initBondsvalue associated to each Game Type (0.08 ether).
packages/contracts-bedrock/test/opcm/DeployImplementations.t.sol
Outdated
Show resolved
Hide resolved
Author
Addressed the init bonds here. For the other one we will take no action as the argument is indeed used by the script. |
0xniha
reviewed
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeDCIfunction, ensures the right OPCM address is used depending on the Dev Flag.DeployOPChain.s.sol:requires incheckInputCloses OPT-1384
Closes OPT-1348
Closes OPT-1344