feat: add interop migration support for opcmv2 in op-deployer #783

0xniha · 2025-12-23T22:22:17Z

No description provided.

…m#18628) Required for Kona

…reum-optimism#18386) * op-service: new bgpo module * op-batcher, op-service: integrate bgpo * op-service, op-batcher: wait for cache prepopulation; DefaultPriorityFee; various comments addressed * better comments * downgrade INFO log level to DEBUG * better test

…l - already has comprehensive coverage (ethereum-optimism#18644) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

…-optimism#18593) * WIP: opcmv2 upgrade op chain (#752) * feat: upgrade op chain wip * feat: add deployv2 wip * fix: deployerv2 wip * refactor: remove additional V2 version of scripts * refactor: adds OPCM v2 support for UpgradeOPChain.s.sol * refactor: adds OPCM v2 support for UpgradeSuperchainConfig.s.sol * fix: uses correct json key for upgradeInput * fix: uses correct feature flag for OPCM v2 in devfeatures.go * chore: add json tag to ExtraInstruction --------- Co-authored-by: Flux <[email protected]> * feat: adds intermediary struct for op-deployer upgrade (#759) * feat: adds intermediary struct for op-deployer upgrade * chore: moved upgrade scripts to v6_0_0 * chore: remove v2 go scripts * refactor: make v2_0_0 upgrade path to support both OPCM v1 and v2 * feat: add support for both OPCM v1 and v2 on embedded upgrade * refactor: make v6_0_0 fall back to v2_0_0 * refactor: add extra instructions for upgrade superchain input * test: fix op-deployer tests * chore: remove deploy OP chain test step * test: use systemconfig proxy address * fix: remove the unneeded proxyadmin in OPChainConfig in op-deployer * refactor: revert v2_0_0 changes in favor of a new v6_0_0 that supports OPCMv2 * feat: add v6_0_0 upgrade * fix: check for 0 len OPChainConfigs * chore: pre-pr ready * Merge pull request #764 from defi-wonderland/fix/opcm2-upgradeopchain-comments fix: opcm2 upgradeopchain comments * refactor: remove enshrined v7_0_0 upgrade in op-deployer (#766) * test: use correct game type and pass correct extra instruction to UpgradeOPChain (#768) * test: add missing extra instructions for OPCM v2 input * fix: add correct game type for cannon kona * fix: opcm2 opd test and sc checks (#777) * chore: set test timeout to 30s (#778) --------- Co-authored-by: niha <[email protected]> Co-authored-by: 0xOneTony <[email protected]>

…optimism#18652) * op-supernode: Don't treat all errors as not found. * op-service: Define JSON marshalling for SuperV1 * op-supernode: Update superroot_atTimestamp response format * Move the response type to the eth package so it can be reused. * Remove unnecessary detail * Not found responses still return the CurrentL1 instead of an error to allow challenger to differentiate between proposals in the future and blocks that just haven't been fully processed yet * op-supernode: Make optimistic blocks available even when full super root is not available. * op-supernode: Add JSON tag to data field. * op-supernode: Fix super root calculation * op-supernode: Fix grammar

…imism#18653) * op-challenger: Implement supernode super root provider. Not currently integrated but has unit tests passing. * Fix sorting.

…s comprehensive coverage (ethereum-optimism#18671) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* op-acceptance-tests: fix port collisions * look for expectedID * normalize peerID before comparison

0xiamflux

Excellent work so far, I guess we also will need to add apply tests to check the result of the whole migration.

op-deployer/pkg/deployer/manage/migrate.go

…tion Replace JSON marshaling with proper ABI encoding using w3 library for migrate inputs. Change OPCM version detection from isDevFeatureEnabled to semantic version comparison. Restructure MigrateInputV1 to use nested GameParameters and Proposal structs. Update DisputeGameConfig.GameArgs from Hash to bytes for correct ABI encoding. Add isVersionAtLeast helper for version comparison (OPCM v2 starts at 7.0.0). Update tests and contracts to use version() method instead of feature flags.

0xniha · 2025-12-26T17:10:47Z

Modified files:

op-deployer/pkg/deployer/manage/flags.go
op-deployer/pkg/deployer/manage/migrate.go
op-deployer/pkg/deployer/manage/migrate_test.go
op-deployer/pkg/deployer/opcm/contract.go
packages/contracts-bedrock/scripts/deploy/InteropMigration.s.sol
packages/contracts-bedrock/test/opcm/InteropMigration.t.sol
op-chain-ops/interopgen/deploy.go

0xniha

TODO:

Refactor op-devstack/sysgo/superroot.go

0xniha · 2025-12-26T19:59:04Z

op-chain-ops/interopgen/deploy.go

+				MaxGameDepth:     new(big.Int).SetUint64(l2Cfgs[l2ChainID].DisputeMaxGameDepth),
+				SplitDepth:       new(big.Int).SetUint64(l2Cfgs[l2ChainID].DisputeSplitDepth),
+				InitBond:         big.NewInt(0),
+				ClockExtension:   new(big.Int).SetUint64(l2Cfgs[l2ChainID].DisputeClockExtension),
+				MaxClockDuration: new(big.Int).SetUint64(l2Cfgs[l2ChainID].DisputeMaxClockDuration),


todo: change this types from GameParameters struct to uint64

Q: should we change these flags to strings so we can parse them as bigInts? Right now they’re read as uint64, which doesn’t cover the full 256 bit range.

0xniha · 2025-12-26T19:59:44Z

op-chain-ops/interopgen/deploy.go

 	}, nil
 }

 func MigrateInterop(


TODO: add MigrateInteropV2

For this task, we’ll also need to modify the flow of the Deploy function. We should probably ask OP for guidance on this. One possible approach is to use GlobalOverrides to set the opcmv2 dev feature flag to true here, so it can be passed through to the DeployImplementations script. That would help keep branching on the go side to a minimum.

the DeploySuperchainToL1 method currently uses OptimismPortalInteropDevFlag as feature bitmap, so we would probably need a DeploySuperchainToL1V2 for opcmv2.

op-deployer/pkg/deployer/manage/migrate.go

Inphi and others added 13 commits December 18, 2025 23:25

op-e2e: Fix super proposals in super DG tests (ethereum-optimism#18647)

4315435

op-deployer: Ignore max-code-size limits during deployment (ethereum-…

e257647

…optimism#18642)

op-sync-tester: Support engine_exchangeCapabilities (ethereum-optimis…

897fe64

…m#18628) Required for Kona

op-devstack: Support kona light CL (ethereum-optimism#18627)

3d8f47e

chore(ai-test): skip test/periphery/drippie/dripchecks/CheckTrue.t.so…

7036c32

…l - already has comprehensive coverage (ethereum-optimism#18644) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

op-challenger: Implement supernode super root provider. (ethereum-opt…

903584f

…imism#18653) * op-challenger: Implement supernode super root provider. Not currently integrated but has unit tests passing. * Fix sorting.

chore(ai-test): skip test/universal/StandardBridge.t.sol - already ha…

1c9d0fc

…s comprehensive coverage (ethereum-optimism#18671) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

op-acceptance-tests: fix port collisions (ethereum-optimism#18684)

722b12f

* op-acceptance-tests: fix port collisions * look for expectedID * normalize peerID before comparison

feat: add interop migration support for op-deployer

7b179a0

feat: add opcm v2 input for interop migration

fbfd591

0xniha requested review from 0xOneTony and 0xiamflux December 23, 2025 22:22

0xniha self-assigned this Dec 23, 2025

0xiamflux reviewed Dec 24, 2025

View reviewed changes

op-deployer/pkg/deployer/manage/migrate.go Show resolved Hide resolved

op-deployer/pkg/deployer/manage/migrate.go Outdated Show resolved Hide resolved

0xniha added 2 commits December 24, 2025 11:57

Merge branch 'develop' into feat/opcm2-interop-migrate-deployer

d11ba87

docs: add description comments to migrate.go

f0daee6

0xniha commented Dec 26, 2025

View reviewed changes

0xniha added 3 commits December 26, 2025 17:36

feat: add opcmv2 migrate support to WithSuperRoots

3ba7721

fix: game parameters uint64 types

0b8f44e

refactor: move IsVersionAtLeast helper to utils and add tests

77146fe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add interop migration support for opcmv2 in op-deployer #783

feat: add interop migration support for opcmv2 in op-deployer #783

Uh oh!

0xniha commented Dec 23, 2025

Uh oh!

0xiamflux left a comment

Uh oh!

Uh oh!

Uh oh!

0xniha commented Dec 26, 2025 •

edited

Loading

Uh oh!

0xniha left a comment •

edited

Loading

Uh oh!

0xniha Dec 26, 2025

Uh oh!

0xniha Dec 29, 2025

Uh oh!

0xniha Dec 26, 2025

Uh oh!

0xniha Dec 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

feat: add interop migration support for opcmv2 in op-deployer #783

Are you sure you want to change the base?

feat: add interop migration support for opcmv2 in op-deployer #783

Uh oh!

Conversation

0xniha commented Dec 23, 2025

Uh oh!

0xiamflux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0xniha commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xniha left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xniha Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

0xniha Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

0xniha Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

0xniha Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

0xniha commented Dec 26, 2025 •

edited

Loading

0xniha left a comment •

edited

Loading