fixes and improvements

contracts/actions/liquityV2/stabilityPool/LiquityV2SPDeposit.sol

@@ -64,7 +64,8 @@ contract LiquityV2SPDeposit is ActionBase, LiquityV2Helper {
     function _spDeposit(Params memory _params) internal returns (uint256, bytes memory) {
         IStabilityPool pool = IStabilityPool(IAddressesRegistry(_params.market).stabilityPool());
 
-        uint256 boldGain = _params.doClaim ? pool.getDepositorYieldGain(address(this)) : 0;
+        uint256 boldGain =
+            _params.doClaim ? pool.getDepositorYieldGainWithPending(address(this)) : 0;
 
         uint256 collGain = _params.doClaim
             ? pool.getDepositorCollGain(address(this)) + pool.stashedColl(address(this))

contracts/actions/liquityV2/stabilityPool/LiquityV2SPWithdraw.sol

@@ -66,7 +66,8 @@ contract LiquityV2SPWithdraw is ActionBase, LiquityV2Helper {
     function _spWithdraw(Params memory _params) internal returns (uint256, bytes memory) {
         IStabilityPool pool = IStabilityPool(IAddressesRegistry(_params.market).stabilityPool());
 
-        uint256 boldGain = _params.doClaim ? pool.getDepositorYieldGain(address(this)) : 0;
+        uint256 boldGain =
+            _params.doClaim ? pool.getDepositorYieldGainWithPending(address(this)) : 0;
 
         uint256 collGain = _params.doClaim
             ? pool.getDepositorCollGain(address(this)) + pool.stashedColl(address(this))

contracts/views/LiquityV2View.sol

@@ -235,7 +235,7 @@ contract LiquityV2View is LiquityV2Helper {
         compoundedBOLD = stabilityPool.getCompoundedBoldDeposit(_depositor);
         collGain =
             stabilityPool.getDepositorCollGain(_depositor) + stabilityPool.stashedColl(_depositor);
-        boldGain = stabilityPool.getDepositorYieldGain(_depositor);
+        boldGain = stabilityPool.getDepositorYieldGainWithPending(_depositor);
     }
 
     function getDebtInFront(address _market, uint256 _troveId, uint256 _acc, uint256 _iterations)

test-sol/actions/liquityV2/LiquityV2SPDeposit.t.sol

@@ -111,6 +111,7 @@ contract TestLiquityV2SPDeposit is LiquityV2ExecuteActions, LiquityV2Utils {
         );
 
         wallet.execute(address(cut), vars.executeActionCallData, 0);
+        vm.warp(block.timestamp + 30 days);
 
         (vars.compoundedBOLD, vars.collGain, vars.boldGain) =
             viewContract.getDepositorInfo(address(_market), walletAddr);
@@ -145,6 +146,9 @@ contract TestLiquityV2SPDeposit is LiquityV2ExecuteActions, LiquityV2Utils {
                 vars.senderBoldBalanceAfter,
                 vars.senderBoldBalanceBefore - vars.depositAmount + vars.boldGain
             );
+
+            assertEq(balanceOf(BOLD, walletAddr), 0);
+            assertEq(balanceOf(vars.collToken, walletAddr), 0);
             assertEq(vars.compoundedBOLDAfter, vars.compoundedBOLD + vars.depositAmount);
             assertEq(vars.collGainAfter, 0);
             assertEq(vars.boldGainAfter, 0);

test-sol/actions/liquityV2/LiquityV2SPWithdraw.t.sol

@@ -178,6 +178,8 @@ contract TestLiquityV2SPWithdraw is LiquityV2ExecuteActions, LiquityV2Utils {
 
         _simulateCollGain(_vars.stabilityPool, _vars.simulatedCollGain, _vars.collToken, walletAddr);
 
+        vm.warp(block.timestamp + 30 days);
+
         _vars.senderCollBalanceBefore = balanceOf(_vars.collToken, sender);
 
         _vars.senderBoldBalanceBefore = balanceOf(BOLD, sender);
@@ -225,6 +227,8 @@ contract TestLiquityV2SPWithdraw is LiquityV2ExecuteActions, LiquityV2Utils {
                 _vars.senderBoldBalanceAfter,
                 _vars.senderBoldBalanceBefore + _vars.withdrawAmount + _vars.boldGain
             );
+            assertEq(balanceOf(BOLD, walletAddr), 0);
+            assertEq(balanceOf(_vars.collToken, walletAddr), 0);
             assertEq(_vars.collGainAfter, 0);
             assertEq(_vars.boldGainAfter, 0);
         }