Skip to content

feat: spark collateral switch strategy - DEV-12687#585

Open
sntntn wants to merge 6 commits into
mainfrom
feature/spark-collateral-switch-strategy
Open

feat: spark collateral switch strategy - DEV-12687#585
sntntn wants to merge 6 commits into
mainfrom
feature/spark-collateral-switch-strategy

Conversation

@sntntn

@sntntn sntntn commented May 22, 2026

Copy link
Copy Markdown

Summary

Briefly describe what this change introduces.

Type of change

  • New Feature - A change that adds functionality.
  • Bugfix - A change that resolves an issue.
  • Tweak - A change that modifies existing features.
  • Refactor - Code improvements without changing behavior.
  • Performance - Optimizations for gas or execution efficiency.
  • Documentation - Updates to docs, comments, or NatSpec.
  • Tests - Adding or updating test coverage.
  • Chore - Maintenance, dependencies, CI/CD, deployments or tooling updates.

Details

Provide any additional details if needed.

References

defisaver/automation-sdk#52

Checks

For Strategies

  • Are new tests added for the strategy?
  • Is the strategy deployed and added to the JSON file?

@sntntn sntntn requested a review from rajko-z May 22, 2026 14:34
@sntntn sntntn self-assigned this May 22, 2026
@linear

linear Bot commented May 22, 2026

Copy link
Copy Markdown

DEV-12687

@sntntn sntntn added the feature New feature label May 24, 2026
@sntntn sntntn changed the title feat: add strategy specification (mainnet) - DEV-12687 feat: spark collateral switch strategy - DEV-12687 May 24, 2026
@sntntn sntntn marked this pull request as ready for review May 29, 2026 11:17
@sntntn sntntn marked this pull request as draft May 29, 2026 12:12
@sntntn sntntn marked this pull request as ready for review May 29, 2026 13:06
sntntn and others added 2 commits June 10, 2026 13:54
Comment thread foundry.lock Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo change

Comment thread lib/forge-std

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo change

rajko-z
rajko-z previously approved these changes Jun 15, 2026

@rajko-z rajko-z left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, the tests are good and changes follow aaveV3 implementation.
You can just remove commited forge-std, and foundry-lock changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants