Skip to content

Comments

Added Samsung Galaxy Store IAP#69

Open
Flake174 wants to merge 2 commits intodefold:masterfrom
Flake174:samsung-galaxy-store
Open

Added Samsung Galaxy Store IAP#69
Flake174 wants to merge 2 commits intodefold:masterfrom
Flake174:samsung-galaxy-store

Conversation

@Flake174
Copy link

IAP support for Galaxy Store
(Subscriptions are not implemented)


- `iap.PROVIDER_ID_FACEBOOK`

- `iap.PROVIDER_ID_FACEBOOK`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate. Should be iap.PROVIDER_ID_SAMSUNG

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you

@AGulev
Copy link
Contributor

AGulev commented Feb 11, 2025

I think lib should be added as dependency in build.gradle and included conditionally depends on option in game.project.
See how it's implemented here for example: https://github.com/defold/extension-ironsource/blob/3da966da251d30e3e272e2f6a6649cbd11bf4676/extension-ironsource/manifests/android/build.gradle#L57-L61

@britzl
Copy link
Collaborator

britzl commented Feb 11, 2025

I think lib should be added as dependency in build.gradle and included conditionally depends on option in game.project.

I agree, but it seems like Samsung is only distributing the IAP library as a jar file:

https://developer.samsung.com/iap/programming-guide/integrate-iap-helper-into-your-app.html

@britzl
Copy link
Collaborator

britzl commented Feb 11, 2025

distributing the IAP library as a jar file:

Actually, it is distributed as an .aar file, which would be preferable. In the current PR we have the .aar file unpacked with resources etc. It would be better if our AndroidBundler.java supports .aar files (note sure if it does, should be easy to add!)

@Flake174
Copy link
Author

That's right, samsung sdk is distributed only as .aar file, I unpacked jar and other resources from it

@britzl
Copy link
Collaborator

britzl commented Feb 11, 2025

That's right, samsung sdk is distributed only as .aar file, I unpacked jar and other resources from it

I think we want to make sure our bundler will handle local .aar files to avoid having all of the resources unpacked like they are now. I will look into it!

@britzl
Copy link
Collaborator

britzl commented Mar 11, 2025

defold/extender#861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants