Conversation
vlaaad
reviewed
Nov 24, 2025
vlaaad
left a comment
vlaaad
left a comment
There was a problem hiding this comment.
Is it supposed to work on Windows? If so, please ensure it does.
poki-sdk/editor/poki.editor_script
Outdated
| local function ensure_directory(path) | ||
| local attrs = editor.external_file_attributes(path) | ||
| if not attrs.exists then | ||
| editor.execute("mkdir", "-p", path, { reload_resources = false }) |
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
thank you, I'll test on win/linux
Collaborator
Author
There was a problem hiding this comment.
with this code it works on windows
Collaborator
Author
There was a problem hiding this comment.
linux works as well
Collaborator
Author
There was a problem hiding this comment.
I just found editor.create_directory(resource_path) but not sure if it will work in this case (I think current version is good enough)
vlaaad
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer can assign a preferable shortcut in preferences:
CleanShot.2025-11-24.at.15.36.23.mp4
Fix #13