End of line to end of screen line - #2
Conversation
0738985 to
f9b1652
Compare
|
I talked to Lee Dohm and he said it would not be good to change the function names. He said I should just change register-default-commands. If I would only change this, the register command names would not be consistent with the API. I think the API should be changed to make the function names consistent. |
|
Oh, so someone is already working on atom#7159... I was about to open my own PR 😅 I agree we should rename function names, because we definitely want to have functions/commands for both, selecting to the end of line and to the end of screen line. Also, I believe this PR should also take care of the 🐛 with the end of screen line leaving one character left. Can you take a look at it, @robbertvs? Note that this only happens when one token is split among several lines. |
|
@acontreras89 I agree we should look at the fact that one character is left should be looked at as well, though I think that can be done in a separate pull request because they are different problems concerning different parts of the code. (also changing the API might need some discussion before it can be merged, but correcting the end-of-screen-line selection can be merged immediately.) |
For discussion, do not merge.