Chore: Removed Axios and updated @wordpress/scripts#22
Open
tstokes8040 wants to merge 3 commits into
Open
Conversation
tstokes8040
commented
Jan 4, 2024
tstokes8040
commented
Member
- Removed Axios resolution
- Updated @wordpress/scripts
- Updated PHP file to look for the proper minified file for social.js. (part of @wordpress/scripts upgrade)
rosswintle
approved these changes
Jan 5, 2024
rosswintle
left a comment
rosswintle
left a comment
Contributor
There was a problem hiding this comment.
Yep, this is great.
I tested by pulling the change, running yarn install and yarn build and then using a composer repository path to symlink it into my local ACF site. All is working fine and no errors.
Good catch on that file changing!
We don't need to update this in any of the sites that use it as it's only build time stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.