Skip to content

chore(release): harden Homebrew tap publishing#353

Merged
kdy1 merged 1 commit intomainfrom
kdy1/nodeup-homebrew-hardening
Apr 7, 2026
Merged

chore(release): harden Homebrew tap publishing#353
kdy1 merged 1 commit intomainfrom
kdy1/nodeup-homebrew-hardening

Conversation

@kdy1
Copy link
Copy Markdown
Contributor

@kdy1 kdy1 commented Apr 7, 2026

Summary

  • switch nodeup Homebrew packaging to prebuilt release archives for macOS amd64/arm64 and Linux amd64
  • replace the shared Homebrew PR flow with direct tap main pushes, including empty-tap bootstrap support
  • document the new tap publishing and install contract across release docs and public nodeup docs

Testing

Notes

  • live publication to the real delinoio/homebrew-tap still depends on the new HOMEBREW_TAP_GH_TOKEN secret being configured in GitHub Actions

@kdy1 kdy1 enabled auto-merge (squash) April 7, 2026 18:16
@kdy1 kdy1 merged commit 0da6a15 into main Apr 7, 2026
16 checks passed
@kdy1 kdy1 deleted the kdy1/nodeup-homebrew-hardening branch April 7, 2026 18:16
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce5ebdc9a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if: env.DRY_RUN != 'true'
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
GH_TOKEN: ${{ secrets.HOMEBREW_TAP_GH_TOKEN }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve GH_TOKEN fallback in release workflows

This step overwrites GH_TOKEN with secrets.HOMEBREW_TAP_GH_TOKEN, so if the new secret is not present yet the value becomes empty and update-homebrew.sh aborts in non-dry-run mode (HOMEBREW_TAP_GH_TOKEN (or GH_TOKEN) is required). Because prior releases used secrets.GH_TOKEN and the script still supports that fallback, this change can block nodeup (and the same pattern in derun/dexdex) releases during secret migration. Use a workflow-level fallback so existing GH_TOKEN continues to work until all environments are updated.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant