release: switch signing sidecars to sigstore bundles#358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.sig/.pemsidecars to Sigstore bundle sidecars*.sigstore.jsonbundles withcosign verify-blob --bundleEvidence
release-nodeupfailure in GitHub Actions wherecosign v3.0.5rejected the oldsign-blobinvocationcosign v3.0.5now producesSHA256SUMSplus*.sigstore.jsonand verifies successfullyCurrent Gap
cosignbehavior.sig/.pemartifactsProposed Scope
scripts/release/generate-checksums.shto emit bundle sidecars onlynodeup,derun, anddexdexAcceptance Criteria
SHA256SUMSand*.sigstore.jsonsidecars without legacy.sig/.pemfilesTest Scenarios
bash -n scripts/release/generate-checksums.sh scripts/install/nodeup.sh scripts/install/derun.sh scripts/install/dexdex-stack.shcosign v3.0.5smoke test for bundle generation andverify-blob --bundlepnpm --filter public-docs testOut of Scope
nodeup@v0.1.10.sig/.pem-only releases