release: Expand Rust release platform targets#372
Conversation
kdy1
changed the title
…ase-platforms # Conflicts: # docs/crates-with-watch-foundation.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e441c994a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "arm64" { "arm64" } | ||
| default { throw "[install.nodeup] unsupported Windows architecture: $architecture" } | ||
| } | ||
| $assetName = "nodeup-windows-$assetArch.zip" |
There was a problem hiding this comment.
After this change, direct install can select nodeup-windows-arm64.zip, but the script still copies a fixed nodeup.exe from the extracted directory. In the release workflow, Windows archives are built from nodeup-${asset_os}-${asset_arch}.exe (for arm64: nodeup-windows-arm64.exe), so the extracted filename does not match the hardcoded copy path and install fails with a missing-file error on Windows ARM64 direct installs.
Useful? React with 👍 / 👎.
1 participant
Summary
cargo-mono,nodeup, andwith-watchrelease workflows to ship Linux ARM64 and Windows ARM64 artifacts on native ARM runnersnodeupandwith-watchnodeupWindows x64 and ARM64 to supported hosts with archive-format-aware runtime resolution, zip extraction, and installer updatesTesting
cargo testpnpm --filter public-docs test./scripts/release/update-homebrew.sh --project nodeup --formula-repo . --version 0.0.0 --darwin-amd64-url https://example.com/nodeup-darwin-amd64.tar.gz --darwin-amd64-sha256 1111111111111111111111111111111111111111111111111111111111111111 --darwin-arm64-url https://example.com/nodeup-darwin-arm64.tar.gz --darwin-arm64-sha256 2222222222222222222222222222222222222222222222222222222222222222 --linux-amd64-url https://example.com/nodeup-linux-amd64.tar.gz --linux-amd64-sha256 3333333333333333333333333333333333333333333333333333333333333333 --linux-arm64-url https://example.com/nodeup-linux-arm64.tar.gz --linux-arm64-sha256 4444444444444444444444444444444444444444444444444444444444444444 --dry-run./scripts/release/update-homebrew.sh --project with-watch --formula-repo . --version 0.0.0 --darwin-amd64-url https://example.com/with-watch-darwin-amd64.tar.gz --darwin-amd64-sha256 1111111111111111111111111111111111111111111111111111111111111111 --darwin-arm64-url https://example.com/with-watch-darwin-arm64.tar.gz --darwin-arm64-sha256 2222222222222222222222222222222222222222222222222222222222222222 --linux-amd64-url https://example.com/with-watch-linux-amd64.tar.gz --linux-amd64-sha256 3333333333333333333333333333333333333333333333333333333333333333 --linux-arm64-url https://example.com/with-watch-linux-arm64.tar.gz --linux-arm64-sha256 4444444444444444444444444444444444444444444444444444444444444444 --dry-run