Skip to content

Add prebuilt installers and cargo-binstall metadata#379

Merged
kdy1 merged 1 commit intomainfrom
kdy1/prebuilt-installers-binstall
Apr 11, 2026
Merged

Add prebuilt installers and cargo-binstall metadata#379
kdy1 merged 1 commit intomainfrom
kdy1/prebuilt-installers-binstall

Conversation

@kdy1
Copy link
Copy Markdown
Contributor

@kdy1 kdy1 commented Apr 11, 2026

Summary

  • add verified prebuilt installers for cargo-mono and with-watch on Bash and PowerShell
  • add first-party-only cargo-binstall metadata for cargo-mono, with-watch, and nodeup
  • update internal contracts, crate READMEs, and public docs for direct install and CI usage

Testing

  • cargo test
  • pnpm --filter public-docs test
  • git diff --check
  • smoke-tested scripts/install/cargo-mono.sh --help
  • smoke-tested scripts/install/with-watch.sh --help

Notes

  • pwsh, cosign, and cargo-binstall were not available in the local environment, so their smoke tests were not run here.

@kdy1 kdy1 merged commit 2ea78b8 into main Apr 11, 2026
16 checks passed
@kdy1 kdy1 deleted the kdy1/prebuilt-installers-binstall branch April 11, 2026 05:35
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebf79f85c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


local tmp_dir
tmp_dir="$(mktemp -d)"
trap 'rm -rf "$tmp_dir"' EXIT
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unbound tmp_dir in cargo-mono EXIT trap

tmp_dir is declared as a function-local variable, but the trap is registered for EXIT, which runs after install_direct returns. With set -u, that makes "$tmp_dir" unbound at process exit, so a successful install path still terminates with a non-zero status (tmp_dir: unbound variable). This will break automation that treats installer exit codes as authoritative.

Useful? React with 👍 / 👎.


local tmp_dir
tmp_dir="$(mktemp -d)"
trap 'rm -rf "$tmp_dir"' EXIT
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unbound tmp_dir in with-watch EXIT trap

This has the same failure mode as the cargo-mono installer: tmp_dir is local to install_direct, but the EXIT trap references it after the function scope ends. Under set -u, the trap throws an unbound-variable error and the script exits non-zero even when installation succeeded, which can fail CI/bootstrap flows.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant