Skip to content

Conversation

@jijinp
Copy link
Contributor

@jijinp jijinp commented Jan 9, 2025

This pull request enhances the deletion process for tag bindings in the TaggableResourceReconciler:

  • Skipped already deleting tag bindings to avoid redundant operations.
  • Removed all finalizers in a single operation before deletion.
  • Handled errors during finalizer removal and tag binding deletion more gracefully.

@jijinp jijinp requested a review from a team as a code owner January 9, 2025 08:34
@codacy-production
Copy link

codacy-production bot commented Jan 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8c75a2e1 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8c75a2e) Report Missing Report Missing Report Missing
Head commit (3d118d8) 591 108 18.27%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#30) 26 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jijinp jijinp added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 595b43c Jan 17, 2025
7 checks passed
@jijinp jijinp deleted the fix/tag-binding-deletion branch January 17, 2025 08:48
@github-actions
Copy link

🎉 This PR is included in version 1.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants