Conversation
Signed-off-by: Roland Urbano <roland.urbano@nts.eu>
Signed-off-by: Roland Urbano <roland.urbano@nts.eu>
Collaborator
|
Can one of the admins verify this patch? |
Author
|
I didn't check the Grafana Dashboards as we use Grafana 11 and the CSM dashboards are only supported with <= Grafana 10. But the changes are minimal so impact to the dashboards isn't expected. |
Author
|
Can someone please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reading POWERSTORE_MAX_CONCURRENT_QUERIES from config doesn't work. The variable is shadowed inside an
ifstatement due to reduntante short hand declaration. I've added a new variable similar to theupdateTickIntervalsfunction which is set tomaxPowerStoreConcurrentRequests.GitHub Issues
List the GitHub issues impacted by this PR:
There are no issues in this repository
Checklist:
How Has This Been Tested?
Due to the FATAL logging in error cases, this has been tested manually.
In addition I've added two test cases for success cases.
Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources