-
Notifications
You must be signed in to change notification settings - Fork 66
Bump version to 1.6.3 and add release script with automatic publishing #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: delorenj <[email protected]>
delorenj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great but can we even make it more Automatic by creating a workflow on PR merged into master or Main rather
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
package.json
Outdated
| "scripts": { | ||
| "build": "bunx tsc" | ||
| "build": "bunx tsc", | ||
| "publish": "bun run build && npm publish" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publish script recursively re-invokes npm publish
The new publish script runs npm publish from within a script that itself is the npm publish lifecycle hook. When you execute bun run publish (or npm publish), npm will run the publish lifecycle, hit this script, and re-run npm publish again, leading to an endless publish loop or repeated publish attempts that fail once the first upload completes (e.g., EPUBLISHCONFLICT). This makes the release command unusable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex implement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use Codex here, create an environment for this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the package version to 1.6.3 and introduces a convenience script for streamlined releases.
- Version updated from 1.6.2 to 1.6.3
- New
publishscript added to automate build and publish workflow - CHANGELOG.md updated with version 1.6.3 entry
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated version to 1.6.3 and added new publish script that combines build and npm publish steps |
| CHANGELOG.md | Added version 1.6.3 changelog entry documenting the publish script addition and version bump |
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: Copilot <[email protected]>
- Updated CHANGELOG.md to reflect script rename from 'publish' to 'release' - Added new GitHub workflow (publish-npm.yml) for automatic NPM publishing on PR merge to main - Workflow includes proper authentication, build steps, and provenance support Co-authored-by: delorenj <[email protected]>
Added automatic NPM publishing workflow in commit 9efb6ba. The new |
- Remove redundant --access public flag from workflow (already in package.json) - Update CHANGELOG heading from 'Build Script' to 'Release Script' for accuracy Co-authored-by: delorenj <[email protected]>
delorenj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added NPM_TOKEN
Overview
This PR adds a
releasescript to streamline the release workflow, bumps the package version to 1.6.3, and adds automatic NPM publishing on PR merge to main.Changes
Version Bump
1.6.2to1.6.3inpackage.jsonNew Release Script
Added a new
releasescript topackage.jsonthat combines the build and publish steps:This allows maintainers to build and publish the package in a single command:
The script will:
bunx tscAutomatic NPM Publishing
Added a new GitHub Actions workflow (
.github/workflows/publish-npm.yml) that automatically publishes to NPM when PRs are merged to main. The workflow:Note: Repository owner needs to add an
NPM_TOKENsecret to GitHub repository settings for automatic publishing to work.Documentation
CHANGELOG.mdwith a new entry for version 1.6.3 documenting the addition of the release script, automatic publishing workflow, and version bumpBenefits
Testing
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.