-
Notifications
You must be signed in to change notification settings - Fork 66
Update command and args in README for Trello #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bunx gives me this error ``` $ bunx @delorenj/mcp-server-trello error: Script not found "@delorenj/mcp-server-trello" ``` ``` bun x @delorenj/mcp-server-trello ``` runs just fine. fixed README first part to reflect that I am running bun 1.3.4
Summary of ChangesHello @sourman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the command for running the Trello MCP server with Bun from bunx to bun x to fix an error the author encountered. The change in the 'Quick Start with Bun' section is correct. My review includes a comment pointing out that other examples in the README still use the old bunx command, and suggests updating them for consistency to improve the documentation's accuracy.
| "command": "bun", | ||
| "args": ["x", "@delorenj/mcp-server-trello"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change correctly updates the command to use bun x, which fixes the issue you described. Good catch!
For consistency, you might want to update the other occurrences of bunx in this file as well. I noticed a few other places where the old command is still being used:
- The 'Quick Start with npx / pnpx / bunx' section (lines 79-80)
- The
mise execexample (line 97) - The
smitheryexample (line 157) - The 'Integration Examples' section (lines 768-769 and 776-777)
Also, the descriptive text just above this code block (line 54) still says 'using bunx'. It would be great to update that to bun x to avoid confusion.
bunx gives me this error
runs just fine. fixed README first part to reflect that
I am running bun 1.3.4