Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

What changes are proposed in this pull request?

This PR refactors the table features implementation by unifying the separate ReaderFeature and WriterFeature enums into a single TableFeature enum, introducing proper feature type classification, and adding validation to ensure protocol correctness.

Added validate_table_features() method to Protocol that enforces:
- Reader features must be ReaderWriter type and also present in writer features
- Writer features must be either Writer type or also present in reader features (if ReaderWriter)

How was this change tested?

Fix all tests to use the unified table features

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 95.55556% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.68%. Comparing base (40bc46b) to head (e69c32a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/actions/mod.rs 95.52% 9 Missing and 2 partials ⚠️
kernel/src/table_features/mod.rs 94.89% 5 Missing ⚠️
kernel/src/table_configuration.rs 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
+ Coverage   84.65%   84.68%   +0.03%     
==========================================
  Files         115      116       +1     
  Lines       29601    29905     +304     
  Branches    29601    29905     +304     
==========================================
+ Hits        25059    25326     +267     
- Misses       3331     3366      +35     
- Partials     1211     1213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Oct 17, 2025
@DrakeLin DrakeLin force-pushed the drake-lin_data/unify-table-features branch from aa502d6 to f1a31e9 Compare October 17, 2025 22:22
@DrakeLin DrakeLin force-pushed the drake-lin_data/unify-table-features branch from f1a31e9 to d3819cf Compare October 18, 2025 00:25
@rtyler rtyler marked this pull request as draft October 20, 2025 02:09
@DrakeLin DrakeLin force-pushed the drake-lin_data/unify-table-features branch from d3819cf to ad80cb0 Compare October 21, 2025 20:56
@DrakeLin DrakeLin force-pushed the drake-lin_data/unify-table-features branch from ad80cb0 to e69c32a Compare October 22, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change that require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant