Skip to content

[WIP] feat: unify table features #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+652 −432
Draft

[WIP] feat: unify table features #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kernel/src/actions/crc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ mod tests {
use crate::engine::sync::SyncEngine;
use crate::schema::derive_macro_utils::ToDataType as _;
use crate::schema::{ArrayType, DataType, StructField, StructType};
use crate::table_features::{ReaderFeature, WriterFeature};
use crate::table_features::TableFeature;
use crate::utils::test_utils::string_array_to_engine_data;
use crate::Engine;

Expand Down Expand Up @@ -252,8 +252,8 @@ mod tests {
let expected_protocol = Protocol {
min_reader_version: 3,
min_writer_version: 7,
reader_features: Some(vec![ReaderFeature::ColumnMapping]),
writer_features: Some(vec![WriterFeature::ColumnMapping]),
reader_features: Some(vec![TableFeature::ColumnMapping]),
writer_features: Some(vec![TableFeature::ColumnMapping]),
};
let expected_metadata = Metadata {
id: "testId".to_string(),
Expand Down
Loading
Loading