feat: disallow equal version in log compaction #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
==========================================
- Coverage 83.97% 83.97% -0.01%
==========================================
Files 111 111
Lines 26250 26258 +8
Branches 26250 26258 +8
==========================================
+ Hits 22044 22049 +5
- Misses 3109 3110 +1
- Partials 1097 1099 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklan
approved these changes
Sep 17, 2025
Co-authored-by: Nick Lanham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This is a minor change in log compaction writer where we disallow compacting a single Delta commit. There is no use case for doing so and is something we recently clarified in the Delta protocol.
This PR affects the following public APIs
Log compaction API
How was this change tested?
Updated tests