Skip to content

feat!: Change input to write_json_file to be FilteredEngineData #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 29, 2025

fmt

3551d49
Select commit
Loading
Failed to load commit list.
Merged

feat!: Change input to write_json_file to be FilteredEngineData #1312

fmt
3551d49
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 29, 2025 in 0s

84.79% (+0.03%) compared to fc5ccb0

View this Pull Request on Codecov

84.79% (+0.03%) compared to fc5ccb0

Details

Codecov Report

❌ Patch coverage is 89.76378% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.79%. Comparing base (fc5ccb0) to head (3551d49).

Files with missing lines Patch % Lines
kernel/src/engine/arrow_utils.rs 64.81% 1 Missing and 18 partials ⚠️
ffi/src/scan.rs 0.00% 1 Missing ⚠️
kernel/src/action_reconciliation/log_replay.rs 92.30% 0 Missing and 1 partial ⚠️
kernel/src/checkpoint/mod.rs 66.66% 0 Missing and 1 partial ⚠️
kernel/src/checkpoint/tests.rs 90.00% 0 Missing and 1 partial ⚠️
kernel/src/engine_data.rs 99.24% 1 Missing ⚠️
kernel/src/scan/mod.rs 93.33% 0 Missing and 1 partial ⚠️
kernel/src/scan/state.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   84.76%   84.79%   +0.03%     
==========================================
  Files         113      113              
  Lines       28421    28613     +192     
  Branches    28421    28613     +192     
==========================================
+ Hits        24091    24263     +172     
- Misses       3194     3196       +2     
- Partials     1136     1154      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov