Skip to content
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ffi/src/engine_data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ pub struct ArrowFFIData {
pub schema: FFI_ArrowSchema,
}

#[cfg(feature = "default-engine-base")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too bad the arrow folks didn't implement Default for FFI_ArrowArray and FFI_ArrowSchema

impl ArrowFFIData {
pub fn empty() -> Self {
Self {
array: FFI_ArrowArray::empty(),
schema: FFI_ArrowSchema::empty(),
}
}
}

// TODO: This should use a callback to avoid having to have the engine free the struct
/// Get an [`ArrowFFIData`] to allow binding to the arrow [C Data
/// Interface](https://arrow.apache.org/docs/format/CDataInterface.html). This includes the data and
Expand Down
2 changes: 2 additions & 0 deletions ffi/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ pub use domain_metadata::get_domain_metadata;
pub mod engine_data;
pub mod engine_funcs;
pub mod error;
#[cfg(feature = "default-engine-base")]
pub mod table_changes;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gate the entire feature since it depends on Arrow.

Suggested change
pub mod table_changes;
#[cfg(feature = "default-engine-base")]
pub mod table_changes;

This lets us remove the repeated #[cfg(feature = "default-engine-base")] below

use error::{AllocateError, AllocateErrorFn, ExternResult, IntoExternResult};
pub mod expressions;
#[cfg(feature = "tracing")]
Expand Down
Loading
Loading