Skip to content

Conversation

@nicklan
Copy link
Collaborator

@nicklan nicklan commented Sep 23, 2025

What changes are proposed in this pull request?

Today we don't have a way to just visit all of a CStringMap. You rather have to probe one key at a time, and also somehow know all the keys ahead of time. This just allows visiting all the entries in one go.

How was this change tested?

New unit test

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.42%. Comparing base (af6a5f5) to head (3bdca0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
+ Coverage   84.39%   84.42%   +0.02%     
==========================================
  Files         112      112              
  Lines       27773    27819      +46     
  Branches    27773    27819      +46     
==========================================
+ Hits        23440    23486      +46     
+ Misses       3201     3199       -2     
- Partials     1132     1134       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one nit

@zachschuermann
Copy link
Member

just dawned on me: also we could perhaps do something "nicer" by letting engines do fallible visiting? and then we stop early if the visitor e.g. returns false? but that's probably over-designing and we can add later if we need

.. disregard

@nicklan nicklan merged commit 1ddc026 into delta-io:main Sep 24, 2025
21 checks passed
aleksandarskrbic pushed a commit to aleksandarskrbic/delta-kernel-rs that referenced this pull request Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants