feat(catalog-managed): uc-client commit API #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 84.73% 84.61% -0.12%
==========================================
Files 117 117
Lines 29894 29936 +42
Branches 29894 29936 +42
==========================================
Hits 25330 25330
- Misses 3340 3382 +42
Partials 1224 1224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DrakeLin
reviewed
Oct 22, 2025
| self | ||
| } | ||
|
|
||
| // TODO: expose metadata/protocol (with_metadata, with_protocol) |
There was a problem hiding this comment.
can we put an issue here?
There was a problem hiding this comment.
yea it will generally be part of the larger effort of supporting better UC APIs so gonna wait on those plans to materialize first (this comment is mostly just a marker)
DrakeLin
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
new
commitAPI for uc-client. this is a small, lightweight rust API for thecommitAPI in UC to unblock catalog-managed writes.How was this change tested?
tested in write path POC - since this code is generally in flux (might not even really end up using this client) not spending too much time on testing infrastructure. the plan will be to either explicitly decide to invest in this client, or we just throw this out and depend on a different one