refactor: Separate domain metadata additions and removals #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
- Coverage 84.79% 84.78% -0.01%
==========================================
Files 118 118
Lines 30366 30376 +10
Branches 30366 30376 +10
==========================================
+ Hits 25748 25755 +7
- Misses 3387 3390 +3
Partials 1231 1231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kernel/src/transaction/mod.rs
Outdated
Comment on lines
139
to
142
| domain_metadatas_to_add: Vec<DomainMetadata>, | ||
| // Domain names to remove in this transaction. The configuration values are fetched during | ||
| // commit from the log to preserve the pre-image in tombstones. | ||
| domains_to_remove: Vec<String>, |
There was a problem hiding this comment.
add_domain_metadata, remove_domains ?
zachschuermann
approved these changes
Oct 24, 2025
| return Err(Error::unsupported( | ||
| "Domain metadata operations require writer version 7 and the 'domainMetadata' writer feature" | ||
| )); | ||
| return Err(Error::generic("Domain metadata operations require writer version 7 and the 'domainMetadata' writer feature")); |
There was a problem hiding this comment.
error change from unsupported -> generic might highlight gap in test coverage? could we add something quick?
Comment on lines
+469
to
+471
| .domain_metadata_additions | ||
| .clone() | ||
| .into_iter() |
There was a problem hiding this comment.
hm.. cloning everything since this method takes &self? is it only used in commit (which takes self)? if so should we just make this take self too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR refactors the internal state management for domain metadata operations to separate additions and removals, cleaning up the internal representation.
How was this change tested?
Existing tests