feat!: arrow 57 support #1424
Open
feat!: arrow 57 support #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
nicklan
reviewed
Oct 23, 2025
| #[cfg(feature = "arrow-56")] | ||
| #[cfg(feature = "arrow-57")] | ||
| mod arrow_compat_shims { | ||
| pub use arrow_57 as arrow; |
There was a problem hiding this comment.
we should probably turn off these warnings if they are spurious
| arrow = ["arrow-57"] # latest arrow version | ||
| need-arrow = [] # need-arrow is a marker that the feature needs arrow dep | ||
|
|
||
| arrow-55 = ["dep:arrow_55", "dep:parquet_55", "object_store", "comfy-table"] |
There was a problem hiding this comment.
I think we're only committing to latest two versions for support, so let's remove arrow-55
| not(feature = "arrow-57") | ||
| ))] | ||
| compile_error!("Requested a feature that needs arrow without enabling arrow. Please enable the `arrow-55` or `arrow-56` feature"); | ||
| compile_error!("Requested a feature that needs arrow without enabling arrow. Please enable the `arrow-55`, `arrow-56`, or `arrow-57` feature"); |
There was a problem hiding this comment.
nit for this message if/when you remove arrow-55
Suggested change
| compile_error!("Requested a feature that needs arrow without enabling arrow. Please enable the `arrow-55`, `arrow-56`, or `arrow-57` feature"); | |
| compile_error!("Requested a feature that needs arrow without enabling arrow. Please enable the `arrow-56`, or `arrow-57` feature"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
add
arrow-57feature flagThis PR affects the following public APIs
arrowflag now defaults to arrow 57 instead of arrow 56.How was this change tested?
existing