Add boundary test cases for UUID length and file extensions #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackintoshrao
force-pushed
the
improvement/add-test-fix
branch
from
f13e850 to
4d3fd87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 80.22% 80.20% -0.03%
==========================================
Files 61 61
Lines 13327 13342 +15
Branches 13327 13342 +15
==========================================
+ Hits 10692 10701 +9
- Misses 2090 2094 +4
- Partials 545 547 +2 ☔ View full report in Codecov by Sentry. |
scovich
reviewed
Nov 14, 2024
zachschuermann
approved these changes
Nov 15, 2024
|
@hackintoshrao can you update this PR with the latest changes in |
added 2 commits
November 16, 2024 09:08
This commit adds explicit boundary test cases to existing tests: 1. In test_uuid_checkpoint_patterns: - Tests UUID with exactly 35 characters (one too short) - Uses realistic UUID format: "3a0d65cd-4056-49b8-937b-95f9e3ee90e" 2. In test_unknown_invalid_patterns: - Tests file with no extension (returns Ok(None)) - Tests file with empty extension "." (returns Ok(Some) with Unknown type) formatting.
Removes the redundant first assertion Keeps the more specific matches! assertion Uses the more descriptive error message about the 35-character UUID Makes the test more concise while maintaining clarity about what we're testing
hackintoshrao
force-pushed
the
improvement/add-test-fix
branch
from
38ede16 to
0d5ae77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit boundary test cases to existing tests:
In test_uuid_checkpoint_patterns:
In test_unknown_invalid_patterns: