Skip to content

Conversation

@zachschuermann
Copy link
Member

Horray for graduating to delta-io! But now it's time to update all our stale links :) most are just in CHANGELOG.md. Despite most (all?) of them working it seems better to go ahead and normalize everything to the new home.

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@e63e1ad). Learn more about missing BASE report.

Files with missing lines Patch % Lines
kernel/src/log_segment/tests.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage        ?   80.21%           
=======================================
  Files           ?       61           
  Lines           ?    13342           
  Branches        ?    13342           
=======================================
  Hits            ?    10702           
  Misses          ?     2092           
  Partials        ?      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

My only question would be whether it's somehow possible to use relative links more often, so we don't need to care about the repo's current home? (tho it seems unlikely it will move again any time soon, so meh)

@zachschuermann
Copy link
Member Author

Nice catch!

My only question would be whether it's somehow possible to use relative links more often, so we don't need to care about the repo's current home? (tho it seems unlikely it will move again any time soon, so meh)

Thanks! Good idea - I know we can do links to files etc. as relative but not sure if we can do PR links like that

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@zachschuermann zachschuermann merged commit ccf5e9a into delta-io:main Nov 19, 2024
20 checks passed
@zachschuermann zachschuermann deleted the delta-io-replace branch November 19, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants