Skip to content

Conversation

@OussamaSaoudi-db
Copy link
Collaborator

What changes are proposed in this pull request?

This introduces

This PR affects the following public APIs

ScanBuilder becomes parameterized by a Scannable. Existing code with scan_builder: ScanBuilder becomes scan_builder: ScanBuilder<Snapshot>.

How was this change tested?

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 85.07463% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ccf5e9a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
kernel/src/table_changes/mod.rs 84.21% 12 Missing and 6 partials ⚠️
ffi/src/lib.rs 0.00% 1 Missing ⚠️
kernel/src/log_segment/tests.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage        ?   80.25%           
=======================================
  Files           ?       62           
  Lines           ?    13473           
  Branches        ?    13473           
=======================================
  Hits            ?    10813           
  Misses          ?     2107           
  Partials        ?      553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Nov 20, 2024
@OussamaSaoudi-db OussamaSaoudi-db deleted the table_changes_scan branch November 21, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change that require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant