Parameterized scan builder #516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 61 61
Lines 13342 13342
Branches 13342 13342
=======================================
Hits 10702 10702
Misses 2092 2092
Partials 548 548 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nicklan
approved these changes
Nov 21, 2024
hntd187
reviewed
Nov 21, 2024
| pub mod log_replay; | ||
| pub mod state; | ||
|
|
||
| pub trait Scannable {} |
There was a problem hiding this comment.
maybe pub(crate) instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR parameterizes ScanBuilder in preparation for creating a ScanBuilder for
TableChanges.This PR affects the following public APIs
ScanBuilder becomes parameterized by a Scannable. Existing code with scan_builder: ScanBuilder becomes scan_builder: ScanBuilder.
How was this change tested?
Existing tests pass.