Skip to content

Conversation

@ankane
Copy link
Contributor

@ankane ankane commented Nov 21, 2024

What changes are proposed in this pull request?

Hi, this symlinks the license and notice files so they're included in the published crates (related: delta-io/delta-rs#3009).

cd kernel
ln -s ../LICENSE .
ln -s ../NOTICE . 

cd ../derive-macros
ln -s ../LICENSE .
ln -s ../NOTICE . 

How was this change tested?

N/A

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Nov 21, 2024
Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.25%. Comparing base (602cc67) to head (3df07e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   80.24%   80.25%           
=======================================
  Files          61       61           
  Lines       13402    13402           
  Branches    13402    13402           
=======================================
+ Hits        10755    10756    +1     
+ Misses       2093     2091    -2     
- Partials      554      555    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zachschuermann zachschuermann removed the breaking-change Change that require a major version bump label Nov 21, 2024
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nicklan nicklan merged commit e450c05 into delta-io:main Nov 21, 2024
20 checks passed
@ankane
Copy link
Contributor Author

ankane commented Nov 21, 2024

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants