Skip to content

Conversation

@OussamaSaoudi-db
Copy link
Collaborator

@OussamaSaoudi-db OussamaSaoudi-db commented Nov 22, 2024

What changes are proposed in this pull request?

This removes files that were accidentally added in prior PRs that were un-reviewed in #505 and #506.

How was this change tested?

@OussamaSaoudi-db OussamaSaoudi-db changed the title Remove Un-reviewed Code Remove un-reviewed Code Nov 22, 2024
@github-actions github-actions bot added the breaking-change Change that require a major version bump label Nov 22, 2024
Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to revert kernel/src/table_changes/scan.rs

and we can include detail in the PR desc. that this removes unreviewed code etc

@OussamaSaoudi-db OussamaSaoudi-db changed the title Remove un-reviewed Code revert kernel/src/table_changes/scan.rs Nov 22, 2024
@OussamaSaoudi-db OussamaSaoudi-db changed the title revert kernel/src/table_changes/scan.rs Revert kernel/src/table_changes/scan.rs Nov 22, 2024
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assume tests pass

@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (329b16b) to head (ad1de57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   80.43%   80.43%   -0.01%     
==========================================
  Files          62       62              
  Lines       13645    13645              
  Branches    13645    13645              
==========================================
- Hits        10976    10975       -1     
- Misses       2112     2114       +2     
+ Partials      557      556       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@OussamaSaoudi-db OussamaSaoudi-db merged commit 4a0fad2 into delta-io:main Nov 22, 2024
19 of 20 checks passed
@OussamaSaoudi-db OussamaSaoudi-db deleted the rm_table_changes_builder branch November 22, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change that require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants