Skip to content

Conversation

@zachschuermann
Copy link
Member

two quick fixes:

  1. skip windows for arrow integration test in PRs
  2. remove 'edited' pr target for semver checks (don't trigger when PR description changes)

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (6c03323) to head (5fcebcc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          67       67           
  Lines       14496    14496           
  Branches    14496    14496           
=======================================
  Hits        11752    11752           
  Misses       2172     2172           
  Partials      572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachschuermann
Copy link
Member Author

zachschuermann commented Nov 27, 2024

hold off: need to debug this - looks like it totally skipped the arrow integration tests..

EDIT: fixed

@zachschuermann
Copy link
Member Author

well - not ideal but it works now. We have it skipping the windows test by skipping all the parts of it. When I tried a job-level if it didn't allow access to the matrix which we need to determine it's windows. Gonna go ahead and merge this and we can iterate in the future if we want to clean it up

@zachschuermann zachschuermann merged commit cd31a07 into delta-io:main Dec 4, 2024
20 checks passed
@zachschuermann zachschuermann deleted the ci-fixes branch December 4, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants