[wip][ffi] transaction and append data FFI #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 83.45% 83.05% -0.40%
==========================================
Files 74 74
Lines 16877 17009 +132
Branches 16877 17009 +132
==========================================
+ Hits 14084 14127 +43
- Misses 2135 2225 +90
+ Partials 658 657 -1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
breaking-change
|
|
||
| #[cfg(feature = "default-engine")] | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn get_engine_data( |
There was a problem hiding this comment.
Nit: Seems we're passing in ownership. Should we call this into_engine_data?
Closed
|
closing in favor of #962 |
OussamaSaoudi
pushed a commit
that referenced
this pull request
Jul 29, 2025
This PR is a retake of #550 ## What changes are proposed in this pull request? This PR implements the ffi functions required to do appends. The main difference over #550 is how it's tested: instead of using a C based example we now opt for a rust-based test that is able to re-used various testing-related utility functions that are used in the kernel tests. To do this cleanly, i've moved several functions over to the test-utils crate. ## This PR affects the following public APIs - Adds new ffi functions related to appends / transactions ## How was this change tested? Using the `test_basic_append` in `ffi/src/transaction/mod.rs`. ## Main points to comment on for reviewers of Draft PR: I would like to draw the reviewer's attention to: - the concept of testing new ffi functionality through rust tests instead of a C example program - usage of `tempfile::tempdir` to create a tmp directory for test data during the test - some outstanding `TODO`s in the `test_basic_append` test Once the current approach is approved by reviewers, I can follow up with more testing: - the write schema - appending to a partitioned table
joonyoo181
pushed a commit
to joonyoo181/delta-kernel-rs
that referenced
this pull request
Aug 5, 2025
This PR is a retake of delta-io#550 ## What changes are proposed in this pull request? This PR implements the ffi functions required to do appends. The main difference over delta-io#550 is how it's tested: instead of using a C based example we now opt for a rust-based test that is able to re-used various testing-related utility functions that are used in the kernel tests. To do this cleanly, i've moved several functions over to the test-utils crate. ## This PR affects the following public APIs - Adds new ffi functions related to appends / transactions ## How was this change tested? Using the `test_basic_append` in `ffi/src/transaction/mod.rs`. ## Main points to comment on for reviewers of Draft PR: I would like to draw the reviewer's attention to: - the concept of testing new ffi functionality through rust tests instead of a C example program - usage of `tempfile::tempdir` to create a tmp directory for test data during the test - some outstanding `TODO`s in the `test_basic_append` test Once the current approach is approved by reviewers, I can follow up with more testing: - the write schema - appending to a partitioned table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Transactionincluding creation, adding commit info, adding write metadata, and committingThis PR affects the following public APIs
TODO
How was this change tested?
write_table